Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Fix for panic from a bug in selecting a filestore block in new fs code. #4520

Merged
merged 1 commit into from Sep 12, 2023
Merged

[FIXED] Fix for panic from a bug in selecting a filestore block in new fs code. #4520

merged 1 commit into from Sep 12, 2023

Commits on Sep 12, 2023

  1. Fix for panic from a bug in selecting a block and an index when num b… 

    …locks > 32 and we used new binary search in NumPending().

The reason would be that we were not accounting for gaps as mb.first.seq can move. The behavior should always return a valid index and mb if seq is inclusive of range from first to last.
The panic could orphan held locks for filestore, consumer and possibly stream.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    244ff44 View commit details
    Browse the repository at this point in the history