Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Concurrent map access for preAcks. #4012

Merged
merged 10 commits into from Apr 2, 2023
Merged

[FIXED] Concurrent map access for preAcks. #4012

merged 10 commits into from Apr 2, 2023

Commits on Apr 2, 2023

  1. Fix for flapper 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    e2839e9 View commit details
    Browse the repository at this point in the history

  2. Do not hold js lock for health check, use healthy not current for meta 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    4b8229e View commit details
    Browse the repository at this point in the history

  3. Gate remove calls, disqualify delivered and ack updates quicker 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    df49829 View commit details
    Browse the repository at this point in the history

  4. Add in monitor status similar to consumer 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    872a9e7 View commit details
    Browse the repository at this point in the history

  5. All should be lowercase 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    e54019f View commit details
    Browse the repository at this point in the history

  6. Snapshot on clean shutdown if needed or interest based retention 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    b752b8b View commit details
    Browse the repository at this point in the history

  7. Wait for shutdown and sleep to let state build up 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    b5358fa View commit details
    Browse the repository at this point in the history

  8. Hold the lock while checking health since we could update catchup state. 

    Do not stepdown right away when executing leadership transfer, wait for the commit.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    874b2b2 View commit details
    Browse the repository at this point in the history

  9. Fix concurrent map bug on preAcks. 

    Use monitor check for streams like consumers.
Make sure to stop raft layer if exiting monitorConsumer early.
Allow consumers to force a snapshot on leadership change.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    a8bd279 View commit details
    Browse the repository at this point in the history

  10. Process replicated ack regardless of store update. Delay but still st… 

    …epdown

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    58ca525 View commit details
    Browse the repository at this point in the history