Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raft log debug reloading #4047

Merged
merged 1 commit into from Apr 13, 2023
Merged

Fix raft log debug reloading #4047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions server/raft.go
View file
Open in desktop
Expand Up @@ -563,11 +563,10 @@ func (s *Server) lookupRaftNode(group string) RaftNode {
return n
}

func (s *Server) reloadDebugRaftNodes() {
func (s *Server) reloadDebugRaftNodes(debug bool) {
if s == nil {
return
}
debug := atomic.LoadInt32(&s.logging.debug) > 0
s.rnMu.RLock()
for _, ni := range s.raftNodes {
n := ni.(*raft)
Expand Down
4 changes: 2 additions & 2 deletions server/reload.go
View file
Open in desktop
@@ -1,4 +1,4 @@
// Copyright 2017-2022 The NATS Authors
// Copyright 2017-2023 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Expand Down Expand Up @@ -148,7 +148,7 @@ type debugOption struct {
// However we will kick the raft nodes if they exist to reload.
func (d *debugOption) Apply(server *Server) {
server.Noticef("Reloaded: debug = %v", d.newValue)
server.reloadDebugRaftNodes()
server.reloadDebugRaftNodes(d.newValue)
}

// logtimeOption implements the option interface for the `logtime` setting.
Expand Down