Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Subscription interest issue due to configuration reload #4130

Merged
merged 4 commits into from May 3, 2023
Merged

[FIXED] Subscription interest issue due to configuration reload #4130

merged 4 commits into from May 3, 2023

Commits on May 3, 2023

  1. Cleanup use of s.opts and fixed some lock (deadlock/inversion) issues 

    One should not access s.opts directly but instead use s.getOpts().
Also, server lock needs to be released when performing an account
lookup (since this may result in server lock being acquired).
A function was calling s.LookupAccount under the client lock, which
technically creates a lock inversion situation.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed May 3, 2023
    Configuration menu
    Copy the full SHA
    840c264 View commit details
    Browse the repository at this point in the history

  2. Fixed accounts configuration reload 

    Issues could manifest with subscription interest not properly
propagated.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed May 3, 2023
    Configuration menu
    Copy the full SHA
    95e4f2d View commit details
    Browse the repository at this point in the history

  3. Fixed Sublist.RemoveBatch to remove subs present, even if one isn't 

    I have seen cases, maybe due to previous issue with configuration
reload that would miss subscriptions in the sublist because
of the sublist swap, where we would attempt to remove subscriptions
by batch but some were not present. I would have expected that
all present subscriptions would still be removed, even if the
call overall returned an error.
This is now fixed and a test has been added demonstrating that
even on error, we remove all subscriptions that were present.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed May 3, 2023
    Configuration menu
    Copy the full SHA
    7afe76c View commit details
    Browse the repository at this point in the history

  4. Updates based on code review 

    Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8a4ead2 View commit details
    Browse the repository at this point in the history