Commits on May 24, 2023

1. [FIXED] LeafNode: data race during validation and create leafnode …

   The issue really was that the test was sharing remote options. The
   way options are used is not ideal since we reference the user provided
   options (but it is relied upon now in many tests and possibly users
   setups). The other side of the issue was that when no local account
   is specified in a "remote" specification, we set it to the global
   account, but that was done when creating the leafnode object (when
   soliciting), which in the case of the test could race with the
   second server doing the validation.
   
   In this PR we move the setting to global account during the validation,
   but also fixed the tests to not share the remote options configuration
   slice between the two servers.
   
   Resolves #4191
   
   Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

   

   kozlovic committed May 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 86a319a
   • Browse repository at this point

   Copy the full SHA

   86a319a View commit details

   Browse the repository at this point in the history