Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-subject limits for MQTT retained messages #4199

Merged
merged 4 commits into from Jun 1, 2023
Merged

Per-subject limits for MQTT retained messages #4199

merged 4 commits into from Jun 1, 2023

Commits on Jun 1, 2023

  1. Per-subject limits for MQTT retained messages 

    Signed-off-by: Neil Twigg <neil@nats.io>
    @neilalexander
    neilalexander committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    7469038 View commit details
    Browse the repository at this point in the history

  2. Migrate old retained messages to new subjects 

    Signed-off-by: Neil Twigg <neil@nats.io>
    @neilalexander
    neilalexander committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    007565f View commit details
    Browse the repository at this point in the history

  3. Add test for MQTT retained message migration 

    Signed-off-by: Neil Twigg <neil@nats.io>
    @neilalexander
    neilalexander committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    4f797a5 View commit details
    Browse the repository at this point in the history

  4. Fixed delivery of retained messages after transfer. 

    I was running a manual test moving from dev to this branch and
noticed that the consumer would receive only 1 message of the 10
messages sent as retained. So I modified the test to verify that
we receive them all and we did not.

The reason was that after the transfer we need to refresh the state
of the stream (stream info) since we attempt to load all messages
based on the state's sequences.

I have also modified a bit the code to update the MaxMsgsPer once
all messages have been transferred.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic @neilalexander
    kozlovic authored and neilalexander committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    a744cb8 View commit details
    Browse the repository at this point in the history