Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Stream recovery with corrupt msg block with sequence gaps. #4344

Merged
merged 2 commits into from Jul 28, 2023
Merged

[FIXED] Stream recovery with corrupt msg block with sequence gaps. #4344

merged 2 commits into from Jul 28, 2023

Commits on Jul 28, 2023

  1. This is a fix for a bad msg blk detected in the field that had sequen… 

    …ce holes.

The stream had max msgs per subject of one and only one subject but had lots of messages.
The stream did not recover correctly, and upon further inspection determined that a msg blk had holes, which should not be possible.

We now detect the holes and deal with the situation appropriately.
Heavily tested on the data dump from the field.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    21e3d7a View commit details
    Browse the repository at this point in the history

  2. Add in const for msg record hash size 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9243051 View commit details
    Browse the repository at this point in the history