Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Accounting drifts #4357

Merged
merged 3 commits into from Aug 2, 2023
Merged

[FIXED] Accounting drifts #4357

merged 3 commits into from Aug 2, 2023

Commits on Aug 2, 2023

  1. Allow long form resolver config to be of type MEM 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b8d1ac9 View commit details
    Browse the repository at this point in the history

  2. Call up to upper layers on Stop() for accounting purposes 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    97827be View commit details
    Browse the repository at this point in the history

  3. Make sure we do not drift on accounting. 

    Three issues were found and resolved.

1. Purge replays after recovery could execute full purge.
2. Callback was registered without lock, which could lead to skew.
3. Cluster reset could stop stream store and recreate it, which could lead to double accounting.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5c8db89 View commit details
    Browse the repository at this point in the history