Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to stop forwarding proposals in consumers after scaling down a stream #4556

Merged
merged 4 commits into from Sep 18, 2023
Merged

Fix to stop forwarding proposals in consumers after scaling down a stream #4556

merged 4 commits into from Sep 18, 2023

Commits on Sep 18, 2023

  1. Add test for scaling replica with pull consumers 

    Signed-off-by: Waldemar Quevedo <wally@synadia.com>
    @wallyqs
    wallyqs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2724589 View commit details
    Browse the repository at this point in the history

  2. When scaling a consumer down make sure to pop the loopAndForwardPropo… 

    …sals go routine

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison @wallyqs
    derekcollison authored and wallyqs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    850c89e View commit details
    Browse the repository at this point in the history

  3. Skip TestJetStreamClusterRestartThenScaleStreamReplicas for now 

    Signed-off-by: Waldemar Quevedo <wally@synadia.com>
    @wallyqs
    wallyqs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ea775a8 View commit details
    Browse the repository at this point in the history

  4. Update to not pop directly, just bail when we detect leadership change 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    71b8a33 View commit details
    Browse the repository at this point in the history