Commits on Sep 28, 2023

1. [FIXED] Race condition in some leader failover scenarios leading to m… …

   …essages being potentially sourced more than once.
   
   - In some failure scenarios where the current leader of a stream sourcing from other stream(s) gets shutdown while publications are happening on the stream(s) being sourced leads to `setLeader(true)` being called on the new leader for the sourcing stream before all the messages having been sourced by the previous leader are completely processed such that when the new leader does it's reverse scan from the last message in it's view of the stream in order to know what sequence number to start the consumer for the stream being sourced from, such that the last message(s) sourced by the previous leader get sourced again, leading to some messages being sourced more than once.
   
   The existing `TestNoRaceJetStreamSuperClusterSources` test would sidestep the issue by relying on the deduplication window in the sourcing stream. Without deduplication the test is a flapper.
   
   This avoid the race condition by adding a small delay before scanning for the last message(s) having been sourced and starting the sources' consumer(s). Now the test (without using the deduplication window) never fails because more messages than expected have been received in the sourcing stream.
   
   - Fix test TestJetStreamWorkQueueSourceRestart that expects the sourcing stream to get all of the expected messages right away by adding a small sleep before checking the number of messages pending on the consumer for that stream.
   
   Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>

   

   jnmoyne committed Sep 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 71f9688
   • Browse repository at this point

   Copy the full SHA

   71f9688 View commit details

   Browse the repository at this point in the history