Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for block with top level comment after value parse bug #5447

Merged
merged 1 commit into from
May 17, 2024
Merged

Test for block with top level comment after value parse bug #5447

merged 1 commit into from
May 17, 2024

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Test for block with top level comment after value parse
fc02b91 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner May 17, 2024 22:12
wallyqs
wallyqs approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 040bae2 into main May 17, 2024
3 of 4 checks passed
@derekcollison derekcollison deleted the lex-test branch May 17, 2024 22:29
@wallyqs wallyqs mentioned this pull request May 20, 2024
Merged
wallyqs added a commit that referenced this pull request May 20, 2024
@wallyqs
Cherry-picks for 2.10.16-RC.3 (#5456)
314f148 
Includes:

- #5447 
- #5449
- #5454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @wallyqs