[ADDED] Name in consumer configuration
#580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this is used, the library will send request to a different API subject space where the stream and consumer names are in the subject, along with a filter subject if one is specified. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
Related to nats-io/nats-architecture-and-design#148 @derekcollison I went with the approach that as long as the new consumer config param "Name" is specified, then the library uses the new subject space, that is, I don't check on server version. The worst case is that the request will timeout. Do you think that checking the server version is required? (of course, always the question: what if client connects to server that is pre 2.9.0 while the server that would handle the request is 2.9.0+ and would be able, but I know that we should have NATS network at the same version level, so I could make the check if you think this is required) |
|
I don't think version check required imo.. |
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
js_cc_secure
branch
from
df7f880
to
2179f21
Compare
aricart
approved these changes
Sep 14, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is used, the library will send request to a different API subject space where the stream and consumer names are in the subject, along with a filter subject if one is specified.
Signed-off-by: Ivan Kozlovic ivan@synadia.com