Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetRevision to nats.KeyValue #903

Merged
merged 3 commits into from Feb 10, 2022

Conversation

matthewdevenny
Copy link
Contributor

Signed-off-by: Matthew DeVenny matt@boxboat.com

Add GetRevision to allow retrieval of historical key value versions by revision number

Signed-off-by: Matthew DeVenny <matt@boxboat.com>
@coveralls
Copy link

coveralls commented Feb 10, 2022

Coverage Status

Coverage decreased (-0.3%) to 85.187% when pulling 14145b0 on boxboatmatt:feature/get-revision into 52371e4 on nats-io:main.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM..

kv.go Outdated Show resolved Hide resolved
kv.go Outdated Show resolved Hide resolved
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
kv.go Outdated Show resolved Hide resolved
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 3ead809 into nats-io:main Feb 10, 2022
kozlovic added a commit to nats-io/nats-architecture-and-design that referenced this pull request Feb 10, 2022
GetRevision returns a specific revision value for the key, or "KeyNotFound" if that message for this revision can't be found. See nats-io/nats.go#903
kozlovic added a commit to nats-io/nats-architecture-and-design that referenced this pull request Feb 11, 2022
GetRevision returns a specific revision value for the key, or "KeyNotFound" if that message for this revision can't be found. See nats-io/nats.go#903

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants