New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetRevision to nats.KeyValue #903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM..
kozlovic
requested changes
Feb 10, 2022
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
kozlovic
requested changes
Feb 10, 2022
Signed-off-by: Matthew DeVenny <matt@boxboat.com>
kozlovic
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kozlovic
added a commit
to nats-io/nats-architecture-and-design
that referenced
this pull request
Feb 10, 2022
GetRevision returns a specific revision value for the key, or "KeyNotFound" if that message for this revision can't be found. See nats-io/nats.go#903
This was referenced Feb 10, 2022
kozlovic
added a commit
to nats-io/nats-architecture-and-design
that referenced
this pull request
Feb 11, 2022
GetRevision returns a specific revision value for the key, or "KeyNotFound" if that message for this revision can't be found. See nats-io/nats.go#903 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthew DeVenny matt@boxboat.com
Add
GetRevision
to allow retrieval of historical key value versions by revision number