Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent error value of context timeout on subscription Fetch() interface. #1011

Merged
merged 2 commits into from Jul 4, 2022
Merged

Consistent error value of context timeout on subscription Fetch() interface. #1011

merged 2 commits into from Jul 4, 2022

Commits on Jul 2, 2022

  1. Add test case about subscription timeout behavior 

    Follow TDD principle, write test watch it fails.
    @wdhongtw
    wdhongtw committed Jul 2, 2022
    Copy the full SHA
    3a46ce2 View commit details
    Browse the repository at this point in the history

  2. Makes context timeout error behavior consistent. 

    If user provides context object and context timeout,
always return the timeout error from context.
    @wdhongtw
    wdhongtw committed Jul 2, 2022
    Copy the full SHA
    37edc5e View commit details
    Browse the repository at this point in the history