Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Ephemeral PullConsumer's Fetch() would fail with "no responders" #1022

Merged
merged 2 commits into from Jul 29, 2022
Merged

[FIXED] Ephemeral PullConsumer's Fetch() would fail with "no responders" #1022

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed719a
Use consumer name in subject for ephemeral
bruth Jul 29, 2022
726f0d8
Add guard for pull mode
bruth Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions js.go
View file
Open in desktop
Expand Up @@ -1662,6 +1662,7 @@ func (js *js) subscribe(subj, queue string, cb MsgHandler, ch chan *Msg, isSync,
// after the AddConsumer returns.
if consumer == _EMPTY_ {
sub.jsi.consumer = info.Name
sub.jsi.nms = fmt.Sprintf(js.apiSubj(apiRequestNextT), stream, info.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do that under condition of if isPullMode {}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 setting the next message subject here would not have side effects for push consumers but better to guard it to be under the check for pull mode just in case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the guard.

}
sub.mu.Unlock()
}
Expand Down