Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve durable consumer unsubscribe comment #1100

Merged
merged 2 commits into from Oct 6, 2022
Merged

Improve durable consumer unsubscribe comment #1100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
005f0e6
Improve durable consumer unsubscribe comment
sylr Oct 5, 2022
f79575e
Apply suggestions from code review
sylr Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions js.go
View file
Open in desktop
Expand Up @@ -67,9 +67,11 @@ type JetStream interface {
// gone.
// * If Durable() option is specified, the library will attempt to lookup a JetStream
// consumer with this name, and if found, will bind to it and not attempt to
// delete it. However, if not found, the library will send a request to create
// such durable JetStream consumer. The library will delete the JetStream consumer
// after an Unsubscribe() or Drain().
// delete it. However, if not found, the library will send a request to
// create such durable JetStream consumer. Note that the library will delete
// the JetStream consumer after an Unsubscribe() or Drain() *only* if it
sylr marked this conversation as resolved.
Show resolved Hide resolved
// created the durable consumer while subscribing. if the durable consumer
sylr marked this conversation as resolved.
Show resolved Hide resolved
// already existed prior to subscribing it won't be deleted.
// * If Bind() option is provided, the library will attempt to lookup the
// consumer with the given name, and if successful, bind to it. If the lookup fails,
// then the Subscribe() call will return an error.
Expand Down