Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] nit: return a more appropriate error #1416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIXED] nit: return a more appropriate error #1416

wants to merge 1 commit into from

Conversation

levb
Copy link
Contributor

@levb levb commented Sep 25, 2023

No description provided.

@levb levb requested a review from piotrpio September 25, 2023 13:00
piotrpio
piotrpio approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding this

piotrpio
piotrpio reviewed Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lev One thing, the same error is also used in UpdateStream() in the same file, could you change it there as well? After doing so, I think we can remove this error from jetstream/errors.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@levb @piotrpio