Update README.md #1475
Open
Update README.md #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reconnect part does not work if you don't include also the PingInterval
|
+1 |
wallyqs
reviewed
Nov 20, 2023
| @@ -341,6 +341,7 @@ nc.QueueSubscribe("foo", "job_workers", func(_ *Msg) { | |||
| // the connection in reconnecting state if it failed to connect right away. | |||
| nc, err := nats.Connect(nats.DefaultURL, | |||
| nats.RetryOnFailedConnect(true), | |||
| nats.PingInterval(time.Second), | |||
There was a problem hiding this comment.
1 sec for the ping interval is super low, 30s to 2 minutes would be a better duration. Though you should not have to set this so would be good to double check the root cause at what what is happening here
There was a problem hiding this comment.
I can bump it up to 30 I agree with you.
|
@p4xx07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reconnect part does not work if you don't include also the PingInterval