Add UserInfoHandler for dynamically fetching username+password #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 1, 2024
This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 1, 2024
This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599
3 tasks
Signed-off-by: btoews <benjamin.toews@gmail.com>
|
Force pushed to add a sign off since the contributing guidelines ask for it. |
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 4, 2024
This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 8, 2024
This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 8, 2024
This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599
btoews
added a commit
to superfly/flyctl
that referenced
this pull request
Apr 8, 2024
* clean up go.mod formatting * allow config struct to be watched for changes on disk * cordination between agent and foreground cmd to keep tokens updated in both * use current tokens when reconnecting to NATS This required forking NATS. I'm trying to get the changes upstreamed in nats-io/nats.go#1599 * debounce config change notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a situation where the user's credentials may have changed by the time a reconnect is being attempted. This PR adds the ability to specify a callback for fetching the current user credentials.