Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked PullSubscribe implementation #791

Merged
merged 1 commit into from Aug 10, 2021
Merged

Reworked PullSubscribe implementation #791

merged 1 commit into from Aug 10, 2021

Commits on Aug 9, 2021

  1. Reworked PullSubscribe implementation 

    Use a SyncSubscription instead. The only visible change from the
user is that calling Fetch() after Unsubscribe() returns ErrBadSubscription
instead of timeout or context deadline exceeded, which makes more
sense to me. This is the only test that I had to tweak.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Aug 9, 2021
    Copy the full SHA
    cfef5e6 View commit details
    Browse the repository at this point in the history