Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Received JetStream message may have wrong subject #827

Merged
merged 1 commit into from Sep 21, 2021

Commits on Sep 21, 2021

  1. [FIXED] Received JetStream message may have wrong subject

    The recent PR #824 tried to optimize reducing memory copy
    by using the non JS, non wildcard subscription's subject
    as the message subject.
    
    However, in case where a NATS subscription is used for
    the delivery subject of a AddConsumer call, then this
    breaks and the message would be received with the subscription
    subject instead of the subject that we get from MSG parsing.
    
    This PR basically reverts changes from #824 and add a subject
    to make sure that we catch such issue in the future.
    
    Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    kozlovic committed Sep 21, 2021
    Copy the full SHA
    3a9b411 View commit details
    Browse the repository at this point in the history