js: Fix context usage with sub.Fetch #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested changes
Oct 5, 2021
The deadline of a context is now used to calculate the time used for `expires` instead of the default `ttl` of the JetStream context which was 5s. This was preventing library users from passing a context with a custom timeout. This also disallows the usage of `context.Background` to make it explicit that `sub.Fetch` has to be used with a context that has a timeout since each fetch request has to include an expire time anyway. In case `context.WithCancel` is used, then a child context with the same duration as the JetStream context default timeout will be created. Also in case msg.Ack it was possible to pass both timeout and a context which would have been ambiguous and only context option being used. Signed-off-by: Waldemar Quevedo <wally@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deadline of a context is now used to calculate the time used for
expiresinstead of the defaultttlof the JetStream context which was5sby default. This was preventing library users from passing a context with a custom timeout.This also disallows the usage of
context.Backgroundto make it explicit thatsub.Fetchhas to be used with a context that has a timeout since each fetch request has to include an expire time anyway.In case
context.WithCancelis used, then a child context with the same duration as the JetStream context default timeout will be created.It is also updated to prevent using both timeout and context options with
msg.InProgress(),msg.AckSync().Fixes #834 #833
Signed-off-by: Waldemar Quevedo wally@synadia.com