Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to KV Watcher. #900

Merged
merged 3 commits into from Feb 8, 2022
Merged

Updates to KV Watcher. #900

merged 3 commits into from Feb 8, 2022

Commits on Feb 6, 2022

  1. Updates to KV Watcher. 

    1. If the underlying stream was very busy pending might not go to zero, so snapshot and mark initial state done when received >= init pending or delta == 0
2. When a watcher was cancelled with a context we would not signal to allow and range w.Updates() calls to exit.
3. General flow control checks were timing sensitive after the initial checks, needed to be 2x HB interval always, not just beginning.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 6, 2022
    Copy the full SHA
    16c1c76 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Do not nil chan, remove mutex 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 7, 2022
    Copy the full SHA
    e6ee279 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Change way to close update chan 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 8, 2022
    Copy the full SHA
    b6d9b13 View commit details
    Browse the repository at this point in the history