Different approach to address initial pending == 0 #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is undoing changes done in PR #901 and makes the changes dicussed in the comments of that PR. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@ripienaar @derekcollison This is another approach, which I sort of prefer. The addconsumer then js.Subscribe() with special option looked a bit of a hack and was not too comfortable with that. @derekcollison Before you complain about use of lock in the watcher :-)
|
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Should be done really only when the library successfully created the consumer. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
ripienaar
reviewed
Feb 10, 2022
| @@ -1573,6 +1566,7 @@ func (js *js) subscribe(subj, queue string, cb MsgHandler, ch chan *Msg, isSync, | |||
| // Since the library created the JS consumer, it will delete it on Unsubscribe()/Drain() | |||
| sub.mu.Lock() | |||
| sub.jsi.dc = true | |||
| sub.jsi.pending = info.NumPending + info.Delivered.Consumer | |||
There was a problem hiding this comment.
good, and this PR is much nicer thanks.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is undoing changes done in PR #901
and makes the changes dicussed in the comments of that PR.
Signed-off-by: Ivan Kozlovic ivan@synadia.com