Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] PurgeDeletes() will now keep markers that are less than 30min old #906

Merged
merged 1 commit into from Feb 15, 2022

Commits on Feb 15, 2022

  1. [CHANGED] PurgeDeletes() will now keep markers that are less than 30m…

    …in old
    
    There is a breaking change where PurgeDeletes() accepts now a list
    of PurgeOpt, not WatchOpt.
    
    We needed from WatchOpt only the context, and as it standed, it was
    bad since user could have passed the IncludeHistory() option to
    PurgeDeletes(), which would likely "break" the functionality.
    
    Also, when invoking PurgeDeletes(), the delete markers than are older than
    a default of 30 minutes will be deleted, however more recent ones will
    be kept. The data is always removed, even if a marker is not.
    
    The user can change the 30 minutes threshold using a new purge
    option called DeleteMarkersOlderThan(duration). If set to -1,
    it restores the old behavior of deleting delete/purge markers,
    regardless of their age.
    
    Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    kozlovic committed Feb 15, 2022
    Copy the full SHA
    4afdb30 View commit details
    Browse the repository at this point in the history