Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Websocket: discovered urls would not have "wss://" scheme #915

Merged
merged 1 commit into from Mar 8, 2022
Merged

[FIXED] Websocket: discovered urls would not have "wss://" scheme #915

merged 1 commit into from Mar 8, 2022

Commits on Feb 18, 2022

  1. [FIXED] Websocket: discovered urls would not have "wss://" scheme 

    If the user originally connects with "wss://" but has not configured
any secure related option (Options.Secure/TLSConfig), then when
adding implicit URLs (from the server INFO) the library would add
the "ws://" prefix to the received URL.
When trying to connect to those URLs, the library would not try
to make a TLS handshake and would get an error back that would
result in a "websocket invalid connection".

Resolves #914

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Feb 18, 2022
    Copy the full SHA
    97d7532 View commit details
    Browse the repository at this point in the history