Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGED] JS: Do not set MaxAckPending to high value on Subscribe #920

Merged
merged 1 commit into from Mar 1, 2022
Merged

[CHANGED] JS: Do not set MaxAckPending to high value on Subscribe #920

merged 1 commit into from Mar 1, 2022

Commits on Mar 1, 2022

  1. [CHANGED] JS: Do not set MaxAckPending to high value on Subscribe 

    When calling js.Subscribe() (or equivalent) and the library ended-up
creating the JS consumer, a MaxAckPending was set to a very high
value in some cases. We now let the server pick the default if the
value is not explicitly set by the user.
The NATS subscription pending limits are set in a way to ensure
that the subscription can store at least the max ack pending value.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
    @kozlovic
    kozlovic committed Mar 1, 2022
    Copy the full SHA
    a68a1fa View commit details
    Browse the repository at this point in the history