Kv parity issues 94, 95, 96 #599
Conversation
… initial end of data marker
… initial end of data marker
… initial end of data marker
| @@ -196,7 +193,8 @@ | |||
| List<KeyValueEntry> history(String key) throws IOException, JetStreamApiException, InterruptedException; | |||
|
|
|||
| /** | |||
| * Remove history from all keys that currently are deleted or purged. | |||
| * Remove history from all keys that currently are deleted or purged | |||
| * with using a default KeyValuePurgeOptions | |||
| * THIS IS A BETA FEATURE AND SUBJECT TO CHANGE | |||
There was a problem hiding this comment.
Can remove the BETA FEATURE comments if PR makes the KV API GA. Alternatively, that could be another PR - up to you.
There was a problem hiding this comment.
I'll do it on another PR
|
|
||
| import java.time.Duration; | ||
|
|
||
| public class KeyValuePurgeOptions { |
|
|
||
| NatsKeyValue(NatsConnection connection, String bucketName, KeyValueOptions kvo) throws IOException { | ||
| this.bucketName = Validator.validateKvBucketNameRequired(bucketName); | ||
| streamName = toStreamName(bucketName); | ||
| streamSubject = toStreamSubject(bucketName); | ||
| defaultKeyPrefix = toKeyPrefix(bucketName); | ||
| rawKeyPrefix = toKeyPrefix(bucketName); |
There was a problem hiding this comment.
Nitpick... Could simplify a bit and remove rawKeyPrefix, just assign to pubSubKeyPrefix and reassign if necessary.
There was a problem hiding this comment.
rawKeyPrefix is the base. pubSubKeyPrefix varies depending on whether or not there is a JetStream prefix
|
|
||
| ZonedDateTime limit; | ||
| if (dmThresh < 0) { | ||
| limit = DateTimeUtils.fromNow(600000); // long enough in the future to clear all |
There was a problem hiding this comment.
May want to assign to a private constant...
There was a problem hiding this comment.
it's the only place it's used. Usually I'm constant crazy, but I like this b/c it stands out, and it's really an arbitrary value anyway.
nats-io/nats-architecture-and-design#94 Items 1 and 3
nats-io/nats-architecture-and-design#95
nats-io/nats-architecture-and-design#96