Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the WithKind trait #1255

Merged
merged 2 commits into from
May 5, 2024
Merged

Remove the WithKind trait #1255

merged 2 commits into from
May 5, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented May 4, 2024

It is actually not used anywhere beyond tests and causes linter to complain

Signed-off-by: Tomasz Pietrek tomasz@nats.io

It is actually not used anywhere beyond tests and causes linter to
complain

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested a review from caspervonb May 4, 2024 20:08
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema merged commit ecdd941 into main May 5, 2024
12 checks passed
@Jarema Jarema deleted the remove-kind-trait branch May 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants