Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consumers with multiple filters #814

Merged
merged 3 commits into from Feb 13, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Jan 19, 2023

Draft until server PR (nats-io/nats-server#3500) is merged.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of showcases the need to make these builders in the long run, lets circle back to that in the future.

lgtm (pending green)

@Jarema
Copy link
Member Author

Jarema commented Jan 19, 2023

Will not be green until server is updated :).

@Jarema
Copy link
Member Author

Jarema commented Feb 6, 2023

addresses #814

@Jarema Jarema marked this pull request as ready for review February 13, 2023 12:04
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the jarema/add-multiple-filters-support branch from f38bc60 to d3f9cee Compare February 13, 2023 15:36
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema merged commit fedc011 into main Feb 13, 2023
@Jarema Jarema deleted the jarema/add-multiple-filters-support branch February 13, 2023 20:29
@Jarema Jarema mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants