Merge pull request #1055 from ripienaar/subj_transform_empty

Prevent empty subject transform settings from being set
nats-io · May 8, 2024 · b9d1498 · b9d1498
2 parents 935f293 + d82d4c6
commit b9d1498
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cli/stream_command.go b/cli/stream_command.go
@@ -18,7 +18,6 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	iu "github.com/nats-io/natscli/internal/util"
 	"io"
 	"math"
 	"os"
@@ -32,6 +31,8 @@ import (
 	"syscall"
 	"time"
 
+	iu "github.com/nats-io/natscli/internal/util"
+
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/choria-io/fisk"
 	"github.com/dustin/go-humanize"
@@ -1653,7 +1654,9 @@ func (c *streamCmd) copyAndEditStream(cfg api.StreamConfig, pc *fisk.ParseContex
 			subjectTransformConfig.Destination = c.subjectTransformDest
 		}
 
-		cfg.SubjectTransform = &subjectTransformConfig
+		if subjectTransformConfig.Source != "" && subjectTransformConfig.Destination != "" {
+			cfg.SubjectTransform = &subjectTransformConfig
+		}
 	}
 
 	return cfg, nil