Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and improvements to GH release workflow #1049

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

mprimi
Copy link
Contributor

@mprimi mprimi commented Apr 26, 2024

  • Make release tag regex stricter (s/./\.)
  • Add missing build step
  • Handle RC releases
  • Update Brew project homepage

@mprimi mprimi added the enhancement Enhancement to existing functionality label Apr 26, 2024
@mprimi mprimi requested a review from ripienaar April 26, 2024 16:21
@@ -6,6 +6,7 @@ release:
name: natscli
name_template: "Release {{.Version}}"
draft: true
prerelease: auto
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will automatically draft a pre-release when appropriate

@@ -61,7 +62,7 @@ brews:
url_template: "https://github.com/nats-io/natscli/releases/download/{{ .Tag }}/nats-{{.Version}}-{{ .Os }}-{{ .Arch }}{{if .Arm}}{{.Arm}}{{end}}.zip"
homepage: "https://github.com/nats-io/nats"
description: "NATS utility"
skip_upload: false
skip_upload: auto
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will automatically skip publishing when it's a RC

@mprimi
Copy link
Contributor Author

mprimi commented Apr 26, 2024

I tested this on my fork, here's examples of what it produces:
https://github.com/mprimi/natscli/releases

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mprimi mprimi merged commit a48bfd0 into nats-io:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants