add compactType=null to remove vertical packing #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents blocks from pushing each other around. pretty much required with "no vertical compacting".
5e-Cleric
reviewed
Mar 3, 2024
| .empty-space { | ||
| height: 100%; | ||
| width: 100%; | ||
| background: rgb(198, 198, 212); |
There was a problem hiding this comment.
this should not be here for printing, its an empty space
5e-Cleric
added
the
🔍 R3 - Reviewed - Awaiting Fixes
…ge, draggables, and nav, with changes to styles, layouts, and class names."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #19 should be merged before this is (this PR includes the changes in #19).
This PR aims at a couple of things:
/components/labelInput/labelInput.cssalong with/components/labelInput/labelInput.jsx). The CSS within is applied to that component in both the picker and the actual page.Minor thing, it also changes the
hoverborder to anoutlinerather thanborder. This prevents minor layout shifts.I still need to get input labels to persist, but i'm not sure that will be in this PR or another (other values also do not currently persist).