Export as HTML, JSON, Import JSON, all but better #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder into separation-of-components
…ic/charactersheetbuilder into separation-of-components
5e-Cleric
changed the title
Closed
5e-Cleric
added
the
🔍 R0 - Needs first review 👀
G-Ambatte
reviewed
Mar 7, 2024
src/components/sheetSettings.jsx
Outdated
|
|
||
| <button | ||
| onClick={() => { | ||
| document.getElementById("importJson").click(); |
There was a problem hiding this comment.
We can eliminate the document.getElementById calls by using React refs instead, in this case it would look like this:
There was a problem hiding this comment.
then grab the file like this?
5e-Cleric
added
🔍 R3 - Reviewed - Awaiting Fixes
…N export functionality, and implemented JSON import feature."
…s, including changes to styles, class names, and local storage keys."
4 tasks
… files, including changes to quotes, indentation, and addition of CSS rules."
|
CSS import for html export is messed up, style filtering doesn't really work right now, find a better way to split styles (comment for myself) |
… removing and reorganizing styles, and updating imports and selectors."
|
Leaving change to refs to a next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some weird coding methods i have been using that need some correcting.