Skip to content
This repository has been archived by the owner on Jan 13, 2020. It is now read-only.

Adds Media Key Support #43

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Vertana
Copy link
Contributor

@Vertana Vertana commented Dec 16, 2018

Allows users to use media keys on the site.

Allows users to use media keys on the site.
@Vertana Vertana mentioned this pull request Dec 16, 2018
@Vertana
Copy link
Contributor Author

Vertana commented Dec 16, 2018

Fixes #16

@naveedgol
Copy link
Owner

This doesn't work with any of the media keys and we shouldn't override the functionality of the arrow keys because that reduces accessibility for keyboard only users.

@Vertana
Copy link
Contributor Author

Vertana commented Dec 23, 2018

@naveedgol You can put in a console.log(event.key) in that case switch in track-controls.component.ts. Just throw that in the default statement at line 74. I did this on Linux using Firefox, so maybe it's an OS-dependent thing and it just needs more switches? As for the arrow keys, you can easily place whatever in the case.

@Vertana
Copy link
Contributor Author

Vertana commented Dec 23, 2018

@naveedgol Changed from arrow keys to WSAD. The media keys work for me, but if they don't work for you then possibly whatever browser you're using isn't following the standard and needs an escape case?
https://www.w3.org/TR/uievents-key/#keys-multimedia

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants