This repository has been archived by the owner on Jan 13, 2020. It is now read-only.
Partially support clicking artists on song search page #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Taking the existing API call and matching the artist with the song allows you to open the artist page directly. Does not work if the search results did not contain the artist.
|
Code looks good and I agree with the idea, but the matching artists to songs by name only seems like a bad idea. Ideally, we could get the artist ID from the song, though that might involve more API calls which may not be worth it. |
|
Hey Naveed, I agree with your points which is why I opted not to include a new API call. You're welcome to take this change in or not, I just had some spare cycles and thought it would be fun to work on this that day. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows you to open the artist page directly. Does not work if the search results
did not contain the artist.
Just kinda threw this together, if you wish to have it a more polished, I'm happy to make requested changes before merging.