Skip to content
This repository has been archived by the owner on Jan 13, 2020. It is now read-only.

Added looping in a track. #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added looping in a track. #7

wants to merge 2 commits into from

Conversation

g14a
Copy link

@g14a g14a commented Dec 13, 2018

Added looping to a track next to play next and play previous using a mat-icon. Functionality is tested. But checking again is advised.

@naveedgol
Copy link
Owner

If you take a look at track-controls.component.html, lines 95-101 are a commented out repeat button that accomplishes the same thing you did. While it repeated fine when playing albums and playlists, it would break if you manipulated your queue. Didn't have a chance to look deeper into what caused this yet.

@g14a
Copy link
Author

g14a commented Dec 13, 2018

Oh, I missed the commented part. Thank you. Could you elaborate the manipulation of the queue part though?

@naveedgol
Copy link
Owner

Play an album with multiple songs, turn repeat on, set a random song to play next. Observe the queue act strange when the album ends and repeats.

@g14a
Copy link
Author

g14a commented Dec 13, 2018

Huh! I noticed how the repeat feature and the queue interact in the official Apple Music app. It was somewhat similar there too. There it asks a confirmation whether we want to add the current particular song to the queue. Well, if I come up with a better solution I'll let you know for sure.Thanks. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants