Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option gap supports setting different values for horizontal and… #104

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: option gap supports setting different values for horizontal and… #104

merged 1 commit into from
Jun 13, 2024
+71 −57

Conversation

coder-layne
Copy link
Contributor

… vertical directions

Issue

#103

Details

  1. The option gap not only accepts a number type but also supports passing an object to separately set horizontal and vertical gaps.
  2. Correspondingly, the grid class has also added methods 'getInlineGap' and 'getContentGap' to retrieve gap values for different scenarios.
  3. Finally, replace the occurrences of 'gap' in derived classes with 'inlineGap' or 'contentGap' as appropriate.

@daybrush daybrush merged commit a0ac92d into naver:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ave10987 ave10987 Awaiting requested review from ave10987

@daybrush daybrush Awaiting requested review from daybrush

@malangfox malangfox Awaiting requested review from malangfox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coder-layne @daybrush