Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oppdatert ktlint til 0.48.2 #1990

Closed
wants to merge 1 commit into from
Closed

Oppdatert ktlint til 0.48.2 #1990

wants to merge 1 commit into from

Conversation

blommish
Copy link
Contributor

@blommish blommish commented Jan 3, 2023

Noen issues som blitt ignorert i .editorconfig

In KtLint 0.48.x the default value for using the trailing comma on declaration site has been changed to true

@blommish blommish requested a review from a team as a code owner January 3, 2023 11:14
)
beskrivelse = "Førstegangsbehandling - manuelt opprettet",
),
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den siste her skjønner jeg ikke helt hvorfor den skal være her.
Vi kan ju også skru av trailing comma.

): List<BehandlingBarn> {
feilHvis(
ustrukturertDokumentasjonType != UstrukturertDokumentasjonType.PAPIRSØKNAD &&
barnSomSkalFødes.isNotEmpty()
barnSomSkalFødes.isNotEmpty(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette blir ju også koko

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enig, dette kan vel ikke være meningen fra ktlint sin side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tolker det som at det er "ønskelig" for multiline-argument 👀 Gir vel kanskje litt mening, men ser stygt ut

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skjønner. Ja, selv om det er best å ha mest mulig default, så ser regelen ut til å være en god kandidat til å ignorere

)

enum class AuditLoggerEvent(val type: String) {
CREATE("create"),
UPDATE("update"),
DELETE("delete"),
ACCESS("access")
ACCESS("access"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fram, tilbake, fram tilbake ... 😂

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blommish blommish changed the title Oppdatert ktlint til 0.48.0 Oppdatert ktlint til 0.48.1 Jan 9, 2023
@blommish blommish changed the title Oppdatert ktlint til 0.48.1 Oppdatert ktlint til 0.48.2 Feb 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blommish blommish deleted the ktlint-0.48.0 branch March 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants