Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service_job_number, service_branch & service_build_url. … #19

Merged
merged 2 commits into from Sep 19, 2020

Conversation

martin-walsh
Copy link
Contributor

@martin-walsh martin-walsh commented Sep 9, 2020

…Also align CircleCI & Travis with node-coveralls.

See:

The variables service_job_number, service_branch & service_build_url have been confirmed to exist by coveralls support. They are as yet undocumented. Some are also in use in the various coveralls libs for node etc.

I have confirmed the service_build_url variable does render a link back to build on coveralls UI

@coveralls
Copy link

coveralls commented Sep 9, 2020

Pull Request Test Coverage Report for Build #53

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build #51: 0.0%
Covered Lines: 263
Relevant Lines: 263

💛 - Coveralls

@martin-walsh
Copy link
Contributor Author

Screen Shot 2020-09-10 at 8 24 25 am

@nbaztec
Copy link
Owner

nbaztec commented Sep 14, 2020

Thanks for the contribution. I'll take a look after this week, since I'm away from my PC at the moment.

@nbaztec nbaztec merged commit 80250e6 into nbaztec:main Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants