Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changeToNegative in NATURAL mode #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BenniG82
Copy link

@BenniG82 BenniG82 commented Jun 20, 2023

This change improves the typing of negative numbers in NATURAL mode when starting to type in an empty/zero-valued field. In NATURAL mode the user expects that typing [-] [1] [2] [3] leads to a field value of e.g. "-$123". With this change input handling is still not perfect in NATURAL mode, but it allows you to continue typing numbers after hitting [-] on an empty/zeroish input.

This change improves the typing of negative numbers in NATURAL mode when starting to type in an empty/zero-valued field.
In NATURAL mode the user expects that typing [-] [1] [2] [3] leads to a field value of  e.g. "$ -123".
With this change input handling is still not perfect in NATURAL mode, but it allows you to continue typing numbers after hitting [-] on an empty/zeroish input.
@BenniG82
Copy link
Author

minus handling

Copy link
Contributor

@ArtemDintecom ArtemDintecom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do this and test with the latest changes in master

@jonsoa
Copy link

jonsoa commented Sep 13, 2023

Is there any news on this issue? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants