Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a 'report missing' feature #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wardellc
Copy link

@wardellc wardellc commented Jun 5, 2019

Added a "report.missing" command line option. When enabled this will report processes which are not running when process-exporter is first ran as having a num_procs of zero. E.g. if firefox isn't running when process-exporter is started and "firefox" is in a "comm" section, the following metric will be reported:

namedprocess_namegroup_num_procs{groupname="firefox"} 0

It uses the "name" field from the process-exporter config file and if the "name" field does not exist it uses all of the process names from the "comm" or "exe" arrays.

This provides a solution to this issue: #59

@rhamon
Copy link

rhamon commented Oct 1, 2019

Would like to use this feature, merge please!

Copy link

@tiagokrebs tiagokrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be quite nice to have this feature

@shdxiang
Copy link

shdxiang commented Feb 6, 2020

Expecting this feature

@rafernandez
Copy link

it'll be great with this feature, merge please ! in advance thanks

@jinnzy
Copy link

jinnzy commented Aug 22, 2020

I modified it on this basis and changed it to report missing if there is report_missing in the configuration file, because some of my services need report missing, and some don’t
https://github.com/jinnzy/process-exporter

process_names:
  - name: auditd
    report_missing: true
    comm:
    - auditd
  - name: NetworkManager
    report_missing: true
    comm:
    - NetworkManager
  - name: puppet
    report_missing: true
    comm:
    - puppet
  - name: "zookeeper"
    comm:
      - "java"
    cmdline:
      - ".*zookeeper/bin.*"

@abhishekgupta-ontic
Copy link

@ncabatoff Any updates on this?

@Lemon-le
Copy link

@ncabatoff Any updates on this?

now ?

@chjohnst
Copy link

Very useful feature for us, we track about a half a dozen system level processes and if they fail to start on boot then we never whether they started or not. Can we get this merged @ncabatoff ?

@mdschmitt
Copy link

@wardellc , it looks like there are merge conflicts now. Mind fixing those and maybe @ncabatoff can merge this? I got caught by this after a reboot just like everyone else.. 😞

@silabeer
Copy link

Very expected feature =(

@kelleranu
Copy link

Would love this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet