Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pentagons #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dncnmcdougall
Copy link

We added pentagons, and displayed more statistics.
We also made the graphs show the average meh'ness of the shapes, and the average sadness.
Part of what was needed to make this work was a trippleslider. We created an nslider, which will automatically transform itself from double- to triple- to four... n- slider depending on the number of inputs. It is probably slightly broken in places.

We did this primarily as a fun exercise.
I am proposing a pull request because Twitter is difficult. Don't pull this. Your code is great as it.

So here is what I wanted to say:
Your code is beautiful.
It is simple to understand and well commented!
We managed to make these hacks in 2 hours because
of the elegant and easy way in which the code is written.

Thank you.

The automatic now supports three shapes.
In addition we created the nslider.js. This is a hack of doubleslider to
allow for n sliders. The number of pieces is determined by the number of
area's given in the config.
The average bored(meh) ratio and average shaking(sad) ratio are now also
graphed. (In yellow and blue respectively.)

We broke the segregation measure. Insteasd of
s = (avg-0.5)*2.
It is now
s = avg.
We did not understand how the computation would change with three shapes,
so we used the raw average.

As a random side note: the code is beautiful.
Easy to read, easy to hack., simple, logical. Thank you.
@captbaritone
Copy link

Is your branch live anywhere? I'd be curious to play with it.

@dncnmcdougall
Copy link
Author

Yes, it is available as a github page here.
Again thanks to Vi Hart and Nicky Case, who made even that possible.

@captbaritone
Copy link

Thanks! Cool idea.

@vihart
Copy link

vihart commented Dec 9, 2014

Cool, thanks for doing this! We'll definitely link it from the main page
next time we edit.

Vi

On Tue, Dec 9, 2014 at 11:17 AM, Jordan Eldredge notifications@github.com
wrote:

Thanks! Cool idea.


Reply to this email directly or view it on GitHub
#4 (comment).

@ncase
Copy link
Owner

ncase commented Dec 11, 2014

The main page now links to the Pentagon sandbox!

Thank you again so much, @dncnmcdougall! :)

Your code is beautiful.

ahahahahahahahahaha good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants