Skip to content

Commit

Permalink
docs(angular): fix missing image in setup mfe guide (nrwl#8816)
Browse files Browse the repository at this point in the history
  • Loading branch information
leosvelperez committed Feb 2, 2022
1 parent 2cf0614 commit c480620
Show file tree
Hide file tree
Showing 9 changed files with 46 additions and 7 deletions.
Binary file added docs/shared/guides/login-app.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/shared/guides/setup-mfe-with-angular.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ nx run login:serve

We can see if we navigate a browser to `http://localhost:4201` that we see the login form rendered:

![Login App](./login-app.png)
![Login App](/shared/guides/login-app.png)

If we type in the correct username and password _(demo, demo)_, then we can also see the user gets authenticated!

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,13 @@ Show what will be generated without writing to disk:
```bash
nx g karma ... --dry-run
```

## Options

### skipPackageJson

Default: `false`

Type: `boolean`

Do not add dependencies to `package.json`.
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,11 @@ Generate a routing setup to allow a host application to route to the remote appl
Type: `boolean`

Skip formatting the workspace after the generator completes.

### skipPackageJson

Default: `false`

Type: `boolean`

Do not add dependencies to `package.json`.
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ Type: `boolean`

Skips formatting the workspace after the generator completes.

### skipPackageJson

Default: `false`

Type: `boolean`

Do not add dependencies to `package.json`.

### stylesEntryPoint

Type: `string`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ Type: `boolean`

Skip formatting files

### skipPackageJson

Default: `false`

Type: `boolean`

Do not add dependencies to `package.json`.

### standaloneConfig

Type: `boolean`
Expand Down
15 changes: 10 additions & 5 deletions nx-dev/nx-dev/public/documentation/shared/angular-plugin.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

![Angular logo](/shared/angular-logo.png)

The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications, and libraries within an Nx workspace. It provides:
The Nx Plugin for Angular contains executors, generators, and utilities for managing Angular applications and libraries within an Nx workspace. It provides:

- Integration with libraries such as Storybook, Jest, Cypress, Karma and Protractor.
- Integration with libraries such as Storybook, Jest, Cypress, Karma, and Protractor.
- Generators to help scaffold code quickly, including:
- Micro Frontends
- Libraries, both internal to your codebase and publishable to npm
Expand Down Expand Up @@ -41,7 +41,7 @@ By default, the application will be generated with:
- Jest as the unit test runner.
- Cypress as the E2E test runner.

We can then serve, build, test, lint and run e2e tests on the application with the following commands:
We can then serve, build, test, lint, and run e2e tests on the application with the following commands:

```bash
nx serve appName
Expand All @@ -51,7 +51,7 @@ nx lint appName
nx e2e appName
```

### Generating an library
### Generating a library

Generating an Angular library is very similar to generating an application:

Expand All @@ -71,7 +71,11 @@ nx test libName
nx lint libName
```

[Read more about generating libraries, including buildable and publishable libraries.]()
Read more about:

- [Creating Libraries](/structure/creating-libraries)
- [Library Types](/structure/library-types)
- [Buildable and Publishable Libraries](/structure/buildable-and-publishable-libraries)

## More Documentation

Expand All @@ -80,3 +84,4 @@ nx lint libName
- [Using NgRx](/guides/misc-ngrx)
- [Using DataPersistence](/guides/misc-data-persistence)
- [Upgrading an AngularJS application to Angular](/guides/misc-upgrade)
- [Using Tailwind CSS with Angular projects](/guides/using-tailwind-css-with-angular-projects)
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ nx run login:serve

We can see if we navigate a browser to `http://localhost:4201` that we see the login form rendered:

![Login App](./login-app.png)
![Login App](/shared/guides/login-app.png)

If we type in the correct username and password _(demo, demo)_, then we can also see the user gets authenticated!

Expand Down

0 comments on commit c480620

Please sign in to comment.