Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tags endpoints #1

Merged
merged 5 commits into from Oct 4, 2020
Merged

feat: add Tags endpoints #1

merged 5 commits into from Oct 4, 2020

Conversation

kvithana
Copy link
Contributor

@kvithana kvithana commented Oct 2, 2020

Hi there!

I added support for the Tags endpoints. Tried to follow your formatting and layout but let me know if I need to fix anything.

Had to bump down Axios due to a known issue with axios.delete() as described at axios/axios#3220

It says it should be fixed in the next version so can update for 0.21?

Possibly for a separate PR, but would be good to have some linting / auto-formatters to ensure consistency. Was using prettier for this with the following config:

{
  "trailingComma": "es5",
  "tabWidth": 2,
  "semi": true,
  "singleQuote": true,
  "printWidth": 100
}

@ndench
Copy link
Owner

ndench commented Oct 4, 2020

Thanks @kvithana! It would be great to get some linters/formatter in here too, feel free to flick through a PR with the settings you used!

@ndench ndench changed the title added Tags endpoints feat: add Tags endpoints Oct 4, 2020
@ndench ndench merged commit 73a1801 into ndench:master Oct 4, 2020
ndench pushed a commit that referenced this pull request Oct 5, 2020
Merge pull request #1 from kvithana/master
@jasonsaayman
Copy link

Hi,

Axios version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants