Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checksum log level #151

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Change checksum log level #151

merged 5 commits into from
Mar 28, 2024

Conversation

gigatexel
Copy link
Contributor

Checksum errors are currently mapped as a "warning" by the logger.

This is unwanted in most cases:

  • Checksum errors tend to happen, sporadically. However, the end user cannot take any action to avoid these sporadic errors and subsequent telegrams are always error-free. The issue solves itself.
  • Errors that are thrown as "warning" do appear in front-end systems, such as Home Assistant. This could cause questions and confusion with end-users that are worried by these warnings.
  • Structural issues in communication require specific investigation by power users. These users are keen enough to level up the default error level from "warning" to, for example, "info"

@ndokter ndokter merged commit 3cf627e into ndokter:master Mar 28, 2024
6 checks passed
@ndokter
Copy link
Owner

ndokter commented Mar 28, 2024

Thanks for the contribution, i will make a new release in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants