Skip to content

Commit

Permalink
Revert dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
@danielgarthur
danielgarthur committed Apr 18, 2024
1 parent d583e17 commit aef3d1a
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 27 deletions.
32 changes: 16 additions & 16 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"dependencies": {
"@ckpack/vue-color": "^1.5.0",
"html-to-image": "^1.11.11",
"i18next": "^23.11.2",
"i18next": "^23.11.0",
"i18next-browser-languagedetector": "^7.2.1",
"i18next-pseudo": "^2.2.1",
"i18next-vue": "^4.0.0",
Expand All @@ -44,7 +44,7 @@
"register-service-worker": "^1.7.2",
"tone": "^14.8.49",
"uuid": "^9.0.1",
"vue": "^3.4.22",
"vue": "^3.4.21",
"vue-draggable-resizable": "^3.0.0",
"vue-facing-decorator": "^3.0.4",
"vue-router": "^4.3.0",
Expand All @@ -54,32 +54,32 @@
"devDependencies": {
"@babel/preset-typescript": "^7.24.1",
"@types/mime-types": "^2.1.4",
"@types/node": "^20.12.7",
"@types/node": "^20.12.5",
"@types/throttle-debounce": "^5.0.2",
"@types/uuid": "^9.0.8",
"@vitejs/plugin-vue": "^5.0.4",
"@vue/eslint-config-prettier": "^9.0.0",
"@vue/eslint-config-typescript": "^13.0.0",
"electron": "^29.3.0",
"electron": "^29.2.0",
"electron-builder": "^24.13.3",
"electron-updater": "^6.1.8",
"eslint": "^8.57.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-simple-import-sort": "^12.1.0",
"eslint-plugin-vue": "^9.25.0",
"eslint-plugin-simple-import-sort": "^12.0.0",
"eslint-plugin-vue": "^9.24.1",
"jest-matcher-deep-close-to": "^3.0.2",
"prettier": "^3.2.5",
"throttle-debounce": "^5.0.0",
"typescript": "^5.4.5",
"typescript": "^5.4.4",
"vite": "^5.2.8",
"vite-plugin-electron": "^0.28.4",
"vite-plugin-electron-renderer": "^0.14.5",
"vite-plugin-eslint": "^1.8.1",
"vite-plugin-pwa": "^0.19.8",
"vite-plugin-vue-devtools": "^7.0.27",
"vitepress": "^1.1.0",
"vitest": "^1.5.0",
"vue-tsc": "^2.0.13"
"vite-plugin-vue-devtools": "^7.0.25",
"vitepress": "^1.0.2",
"vitest": "^1.4.0",
"vue-tsc": "^2.0.11"
},
"overrides": {
"vite-plugin-electron": {
Expand Down

4 comments on commit aef3d1a

@basil
Copy link
Member

@basil basil commented on aef3d1a Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using git bisect.

@danielgarthur
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to use bisect to narrow it down to two commits/issues:

  1. vue 3.4.23 breaks printing
  2. vitepress 1.1.0 depends on vue 3.4.23

So either of those dependency updates breaks printing.

I'm still not sure why that version of vue breaks printing.

@danielgarthur
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause addressed in 4d2d4d7.

I've updated the Vue and vitepress dependencies and print is now working again.

@basil
Copy link
Member

@basil basil commented on aef3d1a Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you beat me as I had just bisected this to vuejs/core#10551. Glad we figured this out before getting too far off the dependency train!

Please sign in to comment.