feat: use the < operator instead of cmp method to improve readability

[jancionear]

The following code is currently used for comparing boundary_account and account_id:

if boundary_account.cmp(account_id) == Greater {
    ...
}

IMO it's a bit confusing - it isn't immediately obvious whether this means boundary_account > account_id or account_id > boundary_account. I misread this line and because of that I made a mistake in #10240.

Let's change it to something that is easier to read:

if account_id < boundary_account {
    ...
}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd80b4c) 71.91% compared to head (cae8e8c) 71.89%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10268      +/-   ##
==========================================
- Coverage   71.91%   71.89%   -0.02%     
==========================================
  Files         707      707              
  Lines      142268   142268              
  Branches   142268   142268              
==========================================
- Hits       102306   102286      -20     
- Misses      35237    35255      +18     
- Partials     4725     4727       +2     

Flag	Coverage Δ
backward-compatibility	0.08% <0.00%> (ø)
db-migration	0.08% <0.00%> (ø)
genesis-check	1.26% <0.00%> (ø)
integration-tests	36.25% <100.00%> (-0.04%)	⬇️
linux	71.77% <100.00%> (+<0.01%)	⬆️
linux-nightly	71.47% <100.00%> (-0.04%)	⬇️
macos	55.09% <100.00%> (+0.01%)	⬆️
pytests	1.49% <0.00%> (ø)
sanity-checks	1.28% <0.00%> (ø)
unittests	68.26% <100.00%> (-0.01%)	⬇️
upgradability	0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akhi3030]

Thank you, much cleaner! Did you consider doing a grep for other instances of cmp that could be replaced with a simpler compare?

[jancionear]

Did you consider doing a grep for other instances of cmp that could be replaced with a simpler compare?

I ran the grep, but I didn't find any other cases where I could justify replacing cmp with a binary operator. In most places cmp is used as intended - for functions that return Ordering, in sort_by, etc

[akhi3030]

Did you consider doing a grep for other instances of cmp that could be replaced with a simpler compare?

I ran the grep, but I didn't find any other cases where I could justify replacing cmp with a binary operator. In most places cmp is used as intended - for functions that return Ordering, in sort_by, etc

Thanks for inspecting!