congestion: runtime test for outgoing buffer #11305
Conversation
|
In draft until #11300 is merged, which this depends on for tests to pass. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11305 +/- ##
==========================================
+ Coverage 71.08% 71.15% +0.07%
==========================================
Files 783 783
Lines 156833 157050 +217
Branches 156833 157050 +217
==========================================
+ Hits 111477 111755 +278
+ Misses 40528 40462 -66
- Partials 4828 4833 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Test on Runtime::apply level that buffering and forwarding works. This is complementary to unit tests in congestion_info.rs, balance_checker.rs, receipt_column_helper.rs, and of course integrations tests.
jakmeier
force-pushed
the
congestion-buffer-apply-test
branch
from
c4674a1
to
14fb2e7
Compare
|
This is ready for review, in theory. But I would rather complete and merge #11307 first and adjust this PR to use the config values. |
fixes a bug introduces in upstream (and update to use config parameters added in upstream)
| @@ -1820,7 +1822,7 @@ impl Runtime { | |||
| proof, | |||
| delayed_receipts_count: delayed_receipts.len(), | |||
| metrics: Some(metrics), | |||
| congestion_info: congestion_info.map(|info| info.congestion_info), | |||
| congestion_info: congestion_control.map(|c| *c.congestion_info()), | |||
There was a problem hiding this comment.
This fixes a bug introduced in #11307.
We must return the modified congestion info, not the input congestion info.
The tests added by in this PR catches it, while existing tests didn't.
|
@wacban this is now ready for review, using the new runtime parameters and updated to use the new interface. Plus a small fix that slipped in and previous tests didn't cover. |
Test on Runtime::apply level that buffering and forwarding works.
This is complementary to unit tests in congestion_info.rs,
balance_checker.rs, receipt_column_helper.rs, and of course
integrations tests.